Skip to content

LimitOffsetPagination limit=0 fix #3444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nhorelik wants to merge 5 commits into from
Closed

LimitOffsetPagination limit=0 fix #3444

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0429201
Added test for limit=0 when using LimitOffsetPagination
nhorelik Sep 24, 2015
145e240
Added page_links check to limit=0 pagination test
nhorelik Sep 24, 2015
08e2071
Fixed ZeroDivisionError on limit=0 in pagination
nhorelik Sep 24, 2015
6d067bc
Changed whitespace to satisfy the linter
nhorelik Sep 25, 2015
1b73517
Fixed missing limit swap in get_next_link
nhorelik Sep 25, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Added test for limit=0 when using LimitOffsetPagination
  • Loading branch information
@nhorelik
nhorelik committed Sep 24, 2015
commit 0429201ddb9276b5e47a1eb48196f4f9c33eac55
15 changes: 15 additions & 0 deletions tests/test_pagination.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,6 +481,21 @@ def test_max_limit(self):
assert content.get('next') == next_url
assert content.get('previous') == prev_url

def test_limit_is_zero(self):
"""
A limit of zero should produce an empty queryset without Exceptions and
otherwise favor the defaults.
"""
request = Request(factory.get('/', {'limit': '0', 'offset': 0}))
queryset = self.paginate_queryset(request)
content = self.get_paginated_content(queryset)
context = self.get_html_context()
next_limit = self.pagination.default_limit
next_offset = self.pagination.default_limit
next_url = 'http://testserver/?limit={0}&offset={1}'.format(next_limit, next_offset)
assert queryset == []
assert content.get('next') == next_url


class TestCursorPagination:
"""
Expand Down