Skip to content

Fix the Django 1.9 compatibility with the Meta api #3511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dulacp wants to merge 5 commits into from
Closed

Fix the Django 1.9 compatibility with the Meta api #3511

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5a72847
Use backward compatible implementation for the meta api calls
dulacp Oct 16, 2015
2cc3b41
Fix the indentation
dulacp Oct 16, 2015
0a89478
Use compat implementations for the old meta api methods
dulacp Oct 16, 2015
f172f0d
Fix the compatibility with the OneToOneField class
dulacp Oct 16, 2015
597b947
Fix the import sorting
dulacp Oct 16, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Use backward compatible implementation for the meta api calls
  • Loading branch information
@dulacp
dulacp committed Oct 16, 2015
commit 5a72847b766e3e58b8002d478040274503d5c8a5
19 changes: 17 additions & 2 deletions rest_framework/utils/model_meta.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,15 @@ def _get_reverse_relationships(opts):
# See: https://code.djangoproject.com/ticket/24208

reverse_relations = OrderedDict()
for relation in opts.get_all_related_objects():

# The backward implementation can be found in the Django Documentation
# See: https://docs.djangoproject.com/en/1.9/ref/models/meta/#migrating-from-the-old-api
related_objects = [
f for f in opts.get_fields()
if (f.one_to_many or f.one_to_one) and f.auto_created
]

for relation in related_objects:
accessor_name = relation.get_accessor_name()
related = getattr(relation, 'related_model', relation.model)
reverse_relations[accessor_name] = RelationInfo(
Expand All @@ -136,8 +144,15 @@ def _get_reverse_relationships(opts):
has_through_model=False
)

# The backward implementation can be found in the Django Documentation
# See: https://docs.djangoproject.com/en/1.9/ref/models/meta/#migrating-from-the-old-api
all_related_to_many_objects = [
f for f in opts.get_fields(include_hidden=True)
if f.many_to_many and f.auto_created
]

# Deal with reverse many-to-many relationships.
for relation in opts.get_all_related_many_to_many_objects():
for relation in all_related_to_many_objects:
accessor_name = relation.get_accessor_name()
related = getattr(relation, 'related_model', relation.model)
reverse_relations[accessor_name] = RelationInfo(
Expand Down