Skip to content

Make tests pass on Windows too #3676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lovelydinosaur merged 4 commits into from
Nov 26, 2015
Merged

Make tests pass on Windows too #3676

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6dcb994
Upgrade transifex-client dependency to 0.11
akx Nov 26, 2015
45c66da
Upgrade isort to 4.2.2.
akx Nov 26, 2015
bdf9c49
Add `types` to isort's standard library list.
akx Nov 26, 2015
47c9bb1
Fix `smart_repr()` to also clean upper-case hex addresses.
akx Nov 26, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix smart_repr() to also clean upper-case hex addresses. 
Windows Pythons seem to like printing addresses in upper-case, while Linux
Pythons like lower-case hexes.

This led to an amusing (for a given value of "amusing", anyway) situation
where some repr tests would fail if the objects they were testing happened
to be allocated at an address with a hex digit in the range A..F.
  • Loading branch information
@akx
akx committed Nov 26, 2015
commit 47c9bb143c3121048957d1078525caaee9f4a10e
2 changes: 1 addition & 1 deletion rest_framework/utils/representation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def smart_repr(value):
# <django.core.validators.RegexValidator object at 0x1047af050>
# Should be presented as
# <django.core.validators.RegexValidator object>
value = re.sub(' at 0x[0-9a-f]{4,32}>', '>', value)
value = re.sub(' at 0x[0-9A-Fa-f]{4,32}>', '>', value)

return value

Expand Down