Skip to content

Updated NestedBoundField to also handle empty string when rendering its form #3677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lovelydinosaur merged 2 commits into from
Nov 27, 2015
Merged

Updated NestedBoundField to also handle empty string when rendering its form #3677

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
570187b
Updated NestedBoundField to also handle empty string when rendering i…
Ernest0x Nov 26, 2015
3594c97
Added test case for rendering nested fields with none value
Ernest0x Nov 27, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Updated NestedBoundField to also handle empty string when rendering i… 
…ts form

If a NestedBoundField field has a value of `None` and is inside another NestedBoundField field, it will have its value converted to an empty string while the form of its enclosing field is being rendered. So, NestedBoundField fields with an empty string value must be handled the same way as NestedBoundField fields with a `None` value.
  • Loading branch information
@Ernest0x
Ernest0x committed Nov 26, 2015
commit 570187b959575822febf838464ea46282cf21654
2 changes: 1 addition & 1 deletion rest_framework/utils/serializer_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ class NestedBoundField(BoundField):
"""

def __init__(self, field, value, errors, prefix=''):
if value is None:
if value is None or value is '':
value = {}
super(NestedBoundField, self).__init__(field, value, errors, prefix)

Expand Down