Skip to content

Raise error when setting a removed rest_framework setting for #3644 #3715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lovelydinosaur merged 17 commits into from
Dec 18, 2015
+31 −1
Merged

Raise error when setting a removed rest_framework setting for #3644 #3715

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
d86a901
Removed Settings raise attribute error
lsanpablo Dec 8, 2015
13c66b9
Return error
lsanpablo Dec 8, 2015
03c7f14
Test case for settings check
lsanpablo Dec 8, 2015
4e5c57a
type on test case
lsanpablo Dec 8, 2015
1b3e433
--ammend
lsanpablo Dec 8, 2015
9db4c2a
--ammend
lsanpablo Dec 8, 2015
4be3535
Merge branch 'settings_errors' of github.com:Cheglader/django-rest-fr…
lsanpablo Dec 8, 2015
5117dad
removed setting typo
lsanpablo Dec 8, 2015
0f85165
Fixed num args for %
lsanpablo Dec 8, 2015
60c4fe1
Refactor Constants
lsanpablo Dec 8, 2015
5802dc0
Initial, fixes #3644
lsanpablo Dec 8, 2015
b6e59c3
Merge branch 'settings_errors' of github.com:Cheglader/django-rest-fr…
lsanpablo Dec 8, 2015
a615e37
Removed depreceated constant
lsanpablo Dec 8, 2015
fbd89d6
Moved SETTINGS_DOC
lsanpablo Dec 12, 2015
dab6bf4
Changed error to warning message
lsanpablo Dec 17, 2015
62e2a97
Fixed import order settings
lsanpablo Dec 17, 2015
c389aeb
Lint import ordring
lsanpablo Dec 17, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed num args for %
  • Loading branch information
@lsanpablo
lsanpablo committed Dec 8, 2015
commit 0f85165b69d8a6db67d3644771c08788a12f68d4
2 changes: 1 addition & 1 deletion rest_framework/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ def __check_user_settings(self, user_settings):
SETTINGS_DOC = "http://www.django-rest-framework.org/api-guide/settings/"
for setting in DEPRECEATED_SETTINGS:
if setting in user_settings:
raise AttributeError("The '%s' setting has been removed. Please refer to '%s' for available settings." % setting, SETTINGS_DOC)
raise AttributeError("The '%s' setting has been removed. Please refer to '%s' for available settings." % (setting, SETTINGS_DOC))
Copy link
Contributor

@xordoquy xordoquy Dec 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want a hard crash or simply a big priority deprecation warning ?

return user_settings


Expand Down