Skip to content
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'reference/master' into 3674-ID-DoesNotE…
…xist

Conflicts:
	tests/test_model_serializer.py
  • Loading branch information
xordoquy committed Jan 20, 2016
commit b7b6ba311dd1850d55f56ae7cd66e3f2d0dd88a5
57 changes: 57 additions & 0 deletions tests/test_model_serializer.py
Original file line number Diff line number Diff line change
Expand Up @@ -884,6 +884,63 @@ class Meta:

assert len(serializer.fields['decimal_field'].validators) == 2

def test_min_value_is_passed(self):
"""
Test that the `MinValueValidator` is converted to the `min_value`
argument for the field.
"""
class TestSerializer(serializers.ModelSerializer):
class Meta:
model = DecimalFieldModel

serializer = TestSerializer()

assert serializer.fields['decimal_field'].min_value == 1

def test_max_value_is_passed(self):
"""
Test that the `MaxValueValidator` is converted to the `max_value`
argument for the field.
"""
class TestSerializer(serializers.ModelSerializer):
class Meta:
model = DecimalFieldModel

serializer = TestSerializer()

assert serializer.fields['decimal_field'].max_value == 3


class TestMetaInheritance(TestCase):
def test_extra_kwargs_not_altered(self):
class TestSerializer(serializers.ModelSerializer):
non_model_field = serializers.CharField()

class Meta:
model = OneFieldModel
read_only_fields = ('char_field', 'non_model_field')
fields = read_only_fields
extra_kwargs = {}

class ChildSerializer(TestSerializer):
class Meta(TestSerializer.Meta):
read_only_fields = ()

test_expected = dedent("""
TestSerializer():
char_field = CharField(read_only=True)
non_model_field = CharField()
""")

child_expected = dedent("""
ChildSerializer():
char_field = CharField(max_length=100)
non_model_field = CharField()
""")
self.assertEqual(unicode_repr(ChildSerializer()), child_expected)
self.assertEqual(unicode_repr(TestSerializer()), test_expected)
self.assertEqual(unicode_repr(ChildSerializer()), child_expected)


class Issue3674Test(TestCase):
def test_nonPK_foreignkey_model_serializer(self):
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.