Skip to content

Fix None UUID ForeignKey serialization #3915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
carltongibson wants to merge 6 commits into from
Closed

Fix None UUID ForeignKey serialization #3915

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ab3f9cf
Fix None UUID ForeignKey serialization
Feb 9, 2016
50782ec
Remove EOL Django 1.7
Feb 9, 2016
665f434
Update release notes.
Feb 10, 2016
14e52ca
Test deserialising data including `None` fk
Feb 10, 2016
363bc4f
Skip UUID tests for Django 1.7
Feb 10, 2016
793d03a
Revert "Remove EOL Django 1.7"
Feb 10, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test deserialising data including None fk
  • Loading branch information
Carlton Gibson committed Feb 10, 2016
commit 14e52ca9745e93870d2e64ef29a06c75b956c660
7 changes: 6 additions & 1 deletion tests/test_relations_pk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ class NullableUUIDForeignKeySourceSerializer(serializers.ModelSerializer):
target = serializers.PrimaryKeyRelatedField(
pk_field=serializers.UUIDField(),
queryset=UUIDForeignKeyTarget.objects.all(),
allow_empty=True)
allow_null=True)

class Meta:
model = NullableUUIDForeignKeySource
Expand Down Expand Up @@ -451,6 +451,11 @@ def test_null_uuid_foreign_key_serializes_as_none(self):
data = serializer.data
self.assertEqual(data["target"], None)

def test_nullable_uuid_foreign_key_is_valid_when_none(self):
data = {"name": "Source", "target": None}
serializer = NullableUUIDForeignKeySourceSerializer(data=data)
self.assertTrue(serializer.is_valid(), serializer.errors)


class PKNullableOneToOneTests(TestCase):
def setUp(self):
Expand Down