Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Closes #3937. Support callable as the value of initial for any `ser…
…ializer.Field`
  • Loading branch information
erickwilder committed Feb 17, 2016
commit 81097520619aef6cd001f85d8bd5ec133a9e20df
2 changes: 2 additions & 0 deletions rest_framework/fields.py
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,8 @@ def get_initial(self):
Return a value to use when the field is being returned as a primitive
value, without any object instance.
"""
if callable(self.initial):
return self.initial()
return self.initial

def get_value(self, dictionary):
Expand Down
18 changes: 18 additions & 0 deletions tests/test_fields.py
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,24 @@ def test_initial(self):
}


class TestInitialWithCallable:
def setup(self):
def initial_value():
return 123

class TestSerializer(serializers.Serializer):
initial_field = serializers.IntegerField(initial=initial_value)
self.serializer = TestSerializer()

def test_initial_should_accept_callable(self):
"""
Follows the default ``Field.initial`` behaviour where they accept a
callable to produce the initial value"""
assert self.serializer.data == {
'initial_field': 123,
}


class TestLabel:
def setup(self):
class TestSerializer(serializers.Serializer):
Expand Down