Skip to content

Conversation

@sasha0
Copy link

@sasha0 sasha0 commented May 8, 2016

refs #4032

@xordoquy
Copy link
Contributor

xordoquy commented May 8, 2016

Seems legit. Will need to properly test to ensure it fixes the original issue.

@xordoquy xordoquy added this to the 3.4.0 Release milestone May 8, 2016
@sasha0
Copy link
Author

sasha0 commented May 8, 2016

Should I add a test case for it?

@xordoquy
Copy link
Contributor

xordoquy commented May 8, 2016

I don't think it's necessary. The tests I was referring to are the one with "real" browsers just to make sure it works(tm) since 303 vs 302 difference is browser specific.

@lovelydinosaur
Copy link
Contributor

I think this thread could do with being a little more specific.
Does this change the browser behavior? If so, how?

@xordoquy
Copy link
Contributor

xordoquy commented May 9, 2016

@tomchristie Everything is explained in the definition of the 303 code. However, I think there should be a location header which I'm not sure is part of the response.

@lovelydinosaur
Copy link
Contributor

Fair enough, although still worth confirming if there are any behavioral changes.

@sasha0
Copy link
Author

sasha0 commented May 10, 2016

@xordoquy don't we set Location header for both types of responses here and here?

@lovelydinosaur
Copy link
Contributor

I'm happy with this change, once someone's confirmed if it makes any behavioral difference to the browser (ie. actually try it out and report on before and after) - if they're the same then great, let's have this as a valid semantic change. If there's differences in the behavior before and after then we can review those on their merits.

@jpadilla
Copy link
Contributor

Just confirmed this does fix original issue.

drf-delete

Although behavior still seems off. Shouldn't we be redirecting back to /users/ after deleting?

@lovelydinosaur lovelydinosaur merged commit 1328982 into encode:master May 16, 2016
@lovelydinosaur
Copy link
Contributor

Shouldn't we be redirecting back to /users/ after deleting?

I think that'd be a valid improvement on DELETE, sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants