Skip to content

Django 1.10 support. #4158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lovelydinosaur merged 14 commits into from
Jun 1, 2016
Merged

Django 1.10 support. #4158

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b0894ed
Added TEMPLATES setting to tests
lovelydinosaur Jun 1, 2016
1a2b325
Remove deprecated view-string in URL conf
lovelydinosaur Jun 1, 2016
f11e24e
Replace 'urls = ...' in test classes with override_settings('ROOT_URL…
lovelydinosaur Jun 1, 2016
9c83ff4
Refactor UsingURLPatterns to use override_settings(ROOT_URLCONF=...) …
lovelydinosaur Jun 1, 2016
96aaa24
Get model managers and names in a version-compatible manner.
lovelydinosaur Jun 1, 2016
46f2ec4
Apply override_settings to a TestCase, not a mixin class
lovelydinosaur Jun 1, 2016
9d1ee6f
Use '.callback' property instead of private attributes when inspectin…
lovelydinosaur Jun 1, 2016
437a125
Pass 'user' to template explicitly
lovelydinosaur Jun 1, 2016
c65c5e4
Correct sorting of import statements.
lovelydinosaur Jun 1, 2016
7ece633
Remove unused TEMPLATE_LOADERS setting, in favor of TEMPLATES.
lovelydinosaur Jun 1, 2016
0ab1aeb
Remove code style issue
lovelydinosaur Jun 1, 2016
b593194
BaseFilter test requires a concrete model
lovelydinosaur Jun 1, 2016
3bdbfdb
Resolve tox.ini issues
lovelydinosaur Jun 1, 2016
3a808a0
Resolve isort differences between local and tox environments
lovelydinosaur Jun 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Pass 'user' to template explicitly
  • Loading branch information
@lovelydinosaur
lovelydinosaur committed Jun 1, 2016
commit 437a12579394ef65f67c4752e6a8a8992c31e9dc
1 change: 1 addition & 0 deletions rest_framework/renderers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,6 +635,7 @@ def get_context(self, data, accepted_media_type, renderer_context):
'view': view,
'request': request,
'response': response,
'user': request.user,
Copy link
Contributor

@xordoquy xordoquy Jun 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed by Django 1.10 ?

Copy link
Contributor Author

@lovelydinosaur lovelydinosaur Jun 1, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For one reason or another, yes.

I've not dug into why yet, but presumably we were previously having it automatically included by the RequestContext. I assume that we could also change our settings in order to resolve this (eg perhaps context processor configuration has moved to being part of the TEMPLATES dictionary?)

In any case it's probably best that we pass it explicitly, rather than relying on the correct context processors being set.

Copy link
Contributor Author

@lovelydinosaur lovelydinosaur Jun 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. Previously we were relying on the default value of TEMPLATE_CONTEXT_PROCESSORS, which includes django.contrib.auth.context_processors.auth.

We could add this in to the TEMPLATES.OPTIONS.context_processors in conftest.py, which would resolve our test cases, but it's better if we pass it explicitly, and not rely on the user settings.

'description': self.get_description(view, response.status_code),
'name': self.get_name(view),
'version': VERSION,
Expand Down
3 changes: 1 addition & 2 deletions tests/browsable_api/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@


class MockView(APIView):

authentication_classes = (authentication.SessionAuthentication,)
renderer_classes = (renderers.BrowsableAPIRenderer,)
renderer_classes = (renderers.BrowsableAPIRenderer, renderers.JSONRenderer)

def get(self, request):
return Response({'a': 1, 'b': 2, 'c': 3})