Skip to content

Improve debug error handling #4416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lovelydinosaur merged 3 commits into from
Aug 18, 2016
Merged

Improve debug error handling #4416

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f2fb69
Improve debug error handling
lovelydinosaur Aug 18, 2016
b3e0c45
Remove redundant code in requests.py
lovelydinosaur Aug 18, 2016
1c67efe
Use HTML tracebacks for the admin interface
lovelydinosaur Aug 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use HTML tracebacks for the admin interface
  • Loading branch information
@lovelydinosaur
lovelydinosaur committed Aug 18, 2016
commit 1c67efe80934354bed21edf2ee9167a4864ba4a9
7 changes: 4 additions & 3 deletions rest_framework/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,9 +438,10 @@ def handle_exception(self, exc):

def raise_uncaught_exception(self, exc):
if settings.DEBUG:
renderer = self.request.accepted_renderer
use_plaintext_traceback = getattr(renderer, 'format') not in ('html', 'api')
self.request.force_plaintext_errors(use_plaintext_traceback)
request = self.request
renderer_format = getattr(request.accepted_renderer, 'format')
use_plaintext_traceback = renderer_format not in ('html', 'api', 'admin')
request.force_plaintext_errors(use_plaintext_traceback)
raise

# Note: Views are made CSRF exempt from within `as_view` as to prevent
Expand Down