Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
0a48d21
fix a b0rked code example in the permissions section of api guide
wimglenn Aug 12, 2016
b508bc8
Merge pull request #4396 from wimglenn/docs_bugfix
jpadilla Aug 13, 2016
075a0bd
Fix template syntax error for `as_list_of_strings` (#4403)
jamesbeith Aug 15, 2016
785b206
Tweak doctsring. Closes #4404 [ci skip]
lovelydinosaur Aug 15, 2016
101fd29
Do not include uploads in request.POST (#4407)
lovelydinosaur Aug 15, 2016
e3f8d06
Include .action attribute on viewsets when generating schemas (#4408)
lovelydinosaur Aug 15, 2016
966330a
Replace utf8 character ' with its ascii counterpart, makes bdist_rpm.…
nevun Aug 17, 2016
b76984d
Allow custom CSRF_HEADER_NAME setting. (#4415)
lovelydinosaur Aug 18, 2016
382ea77
Improve debug error handling (#4416)
lovelydinosaur Aug 18, 2016
59ca61a
Add django-rest-framework-roles to third party packages in permission…
r1b Aug 19, 2016
e5b4498
Initial tests for API client
lovelydinosaur Aug 19, 2016
63342e8
Version 3.4.5 (#4421)
lovelydinosaur Aug 19, 2016
a335309
Add __str__ method to PKOnlyObject (#4423)
lovelydinosaur Aug 19, 2016
d540f02
Improve Create to show the original exception traceback (#3508)
orf Aug 19, 2016
c5e80e1
Merge branch 'master' into api-client
lovelydinosaur Aug 19, 2016
1a73c1c
Initial test cases for API client
lovelydinosaur Aug 19, 2016
e615f6d
Tests for API clients
lovelydinosaur Aug 22, 2016
341fa58
Support raw file uplaods with requests client / api client.
lovelydinosaur Aug 22, 2016
fe706eb
Tweak to tests for py3
lovelydinosaur Aug 22, 2016
b56e7d3
Upload and download support
lovelydinosaur Sep 9, 2016
b41ec30
Py3 compat
lovelydinosaur Sep 9, 2016
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve Create to show the original exception traceback (#3508)
  • Loading branch information
orf authored and lovelydinosaur committed Aug 19, 2016
commit d540f0262b4b0a5f8ce628334d1a812179556002
8 changes: 5 additions & 3 deletions rest_framework/serializers.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
"""
from __future__ import unicode_literals

import traceback
import warnings

from django.db import models
Expand Down Expand Up @@ -870,19 +871,20 @@ def create(self, validated_data):

try:
instance = ModelClass.objects.create(**validated_data)
except TypeError as exc:
except TypeError:
tb = traceback.format_exc()
msg = (
'Got a `TypeError` when calling `%s.objects.create()`. '
'This may be because you have a writable field on the '
'serializer class that is not a valid argument to '
'`%s.objects.create()`. You may need to make the field '
'read-only, or override the %s.create() method to handle '
'this correctly.\nOriginal exception text was: %s.' %
'this correctly.\nOriginal exception was:\n %s' %
(
ModelClass.__name__,
ModelClass.__name__,
self.__class__.__name__,
exc
tb
)
)
raise TypeError(msg)
Expand Down