Skip to content

Router doesn't work if prefix is blank, though project urls.py handles prefix #4486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
c17r wants to merge 2 commits into from
Closed

Router doesn't work if prefix is blank, though project urls.py handles prefix #4486

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a556b9c
Router doesn't work if prefix is blank, though project urls.py handle…
c17r Sep 14, 2016
a372a8e
Check for empty router prefix; adjust URL accordingly
c17r Sep 15, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Check for empty router prefix; adjust URL accordingly 
It's easiest to fix this issue after we have made the regex.  To try
to fix it before would require doing something different for List vs
Detail, which means we'd have to know which type of url we're
constructing before acting accordingly.
  • Loading branch information
@c17r
c17r committed Sep 15, 2016
commit a372a8edea70260ebfb559f3d0bd692132cdfb40
8 changes: 8 additions & 0 deletions rest_framework/routers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ def urls(self):


class SimpleRouter(BaseRouter):

routes = [
# List route.
Route(
Expand Down Expand Up @@ -258,6 +259,13 @@ def get_urls(self):
trailing_slash=self.trailing_slash
)

# If there is no prefix, the first part of the url is probably
# controlled by project's urls.py and the router is in an app,
# so a slash in the beginning will (A) cause Django to give
# warnings and (B) generate URLS that will require using '//'.
if not prefix and regex[:2] == '^/':
regex = '^' + regex[2:]

view = viewset.as_view(mapping, **route.initkwargs)
name = route.name.format(basename=basename)
ret.append(url(regex, view, name=name))
Expand Down