Skip to content

Error codes #4550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lovelydinosaur merged 9 commits into from
Oct 11, 2016
Merged

Error codes #4550

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f078a04
Add 'code' to ValidationError
lovelydinosaur Oct 10, 2016
a6756a1
Add tests, from johnraz
lovelydinosaur Oct 10, 2016
7943429
Rejig ErrorMessages, to prefer code= directly on ValidationError
lovelydinosaur Oct 10, 2016
2eb62d4
Tweaks
lovelydinosaur Oct 10, 2016
ce8eb7e
Added 'get_codes' and 'get_full_details'
lovelydinosaur Oct 10, 2016
117a24c
Add test for get_codes
lovelydinosaur Oct 10, 2016
2a3d07d
Docstrings
lovelydinosaur Oct 10, 2016
e4b961b
Apply error codes to all exception types. Add documentation.
lovelydinosaur Oct 11, 2016
be1d326
Fix typo. [ci skip]
lovelydinosaur Oct 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Docstrings
  • Loading branch information
@lovelydinosaur
lovelydinosaur committed Oct 10, 2016
commit 2a3d07d9d3b8ca0ff8e6b142eb3d68097d67df21
2 changes: 1 addition & 1 deletion docs/api-guide/exceptions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ By default this exception results in a response with the HTTP status code "429 T

## ValidationError

**Signature:** `ValidationError(detail)`
**Signature:** `ValidationError(detail, code=None)`

The `ValidationError` exception is slightly different from the other `APIException` classes:

Expand Down
10 changes: 10 additions & 0 deletions rest_framework/exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,19 @@ def __str__(self):
return six.text_type(self.detail)

def get_codes(self):
"""
Return only the code part of the error details.

Eg. {"name": ["required"]}
"""
return _get_codes(self.detail)

def get_full_details(self):
"""
Return both the message & code parts of the error details.

Eg. {"name": [{"message": "This field is required.", "code": "required"}]}
"""
return _get_full_details(self.detail)


Expand Down