Skip to content

Defer translated string evaluation on validators. #5452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carltongibson merged 2 commits into from
Sep 26, 2017
Merged

Defer translated string evaluation on validators. #5452

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24391db
Customize validators to defer error string evaluation.
Sep 25, 2017
460666d
Add docstring for `CustomValidatorMessage`
Sep 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add docstring for CustomValidatorMessage
  • Loading branch information
Carlton Gibson authored Sep 26, 2017
commit 460666db65657c35ba894e3c322d24dc1694fea1
6 changes: 6 additions & 0 deletions rest_framework/compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,12 @@ def pygments_css(style):
DecimalValidator = None

class CustomValidatorMessage(object):
"""
We need to avoid evaluation of `lazy` translated `message` in `django.core.validators.BaseValidator.__init__`.
https://github.com/django/django/blob/75ed5900321d170debef4ac452b8b3cf8a1c2384/django/core/validators.py#L297

Ref: https://github.com/encode/django-rest-framework/pull/5452
"""
def __init__(self, *args, **kwargs):
self.message = kwargs.pop('message', self.message)
super(CustomValidatorMessage, self).__init__(*args, **kwargs)
Expand Down