aws: don't configure AWS_PROFILE automatically #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plugin currently always set AWS_PROFILE to the persona's name. This is not necessary, as having multiple personas allow to leverage the default profile for each without special AWS configurations. Updates the plugin to accept an additional custom_profile_name configuration that specifies the custom profile name to use. When empty, AWS_PROFILE is not set. When set to `$PERSONA`, the value is replaced with current persona's name. **This is a breaking change.**
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
==========================================
+ Coverage 51.70% 53.84% +2.14%
==========================================
Files 30 35 +5
Lines 441 468 +27
==========================================
+ Hits 228 252 +24
- Misses 187 189 +2
- Partials 26 27 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
awsplugin currently always setAWS_PROFILEto the persona's name. This isnot necessary, as having multiple personas allow to leverage the default
profile for each without special AWS configurations.
Updates the plugin to accept an additional
custom_profile_nameconfigurationthat specifies the custom profile name to use. When empty,
AWS_PROFILEisnot set. When set to
$PERSONA, the value is replaced with currentpersona's name.
This is a breaking change.