blockreward contract #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngyam
force-pushed
the
feat/reward_contract
branch
2 times, most recently
from
8c030cb to
6df8ac6
Compare
- tests + mock contracts included
ngyam
force-pushed
the
feat/reward_contract
branch
from
6df8ac6 to
8606b3d
Compare
- natspec added - tests cleaned: more descriptive variable names
- S curve + tests added - some existing tests reworked/fixed - testing on concrete error messages added - eternal storage/proxy removed
hai-ko
suggested changes
Apr 2, 2019
- getters are also removed cause were unnecessary afterwards
Contributor
Author
|
done @hai-ko |
hai-ko
approved these changes
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP do not merge
@hai-ko @CJentzsch