Skip to content

Conversation

@thicodes
Copy link
Collaborator

About UserList, will we add routes+preloadQuery in preparation or preparedloadQuery within itself?

@renanmav
Copy link
Collaborator

How would you preload the query?

Copy link
Member

@sibelius sibelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good first step

@thicodes
Copy link
Collaborator Author

@renanmav
So, I thought of these 2 solutions:

  • Do inside the UserList. It is simpler, but it would be inappropriate.
  • Use routes - It would be closer to actual use as the issue-tracker.

What do you think?

@thicodes thicodes merged commit 7ed1708 into entria:master Nov 20, 2019
@thicodes thicodes deleted the chore/relay-react-experimental branch November 20, 2019 19:59
@renanmav
Copy link
Collaborator

Both solutions are valid. I prefer to preload on mouse hover.

@thicodes
Copy link
Collaborator Author

thicodes commented Nov 20, 2019

@renanmav
Great! Im going to create a package with an issue-tracker router abstraction and bring the routes, creating a new PR. Thanks!

@renanmav
Copy link
Collaborator

Actually I'm already working on this here with Typescript flow fede \o/

@thicodes
Copy link
Collaborator Author

Wow. Very good!
Thank you very much. I will need a lot @renanmav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants