Skip to content

Remove address_format configuration from template configs#955

Merged
DZakh merged 1 commit intomainfrom
claude/default-checksum-addresses-ae0t3
Feb 16, 2026
Merged

Remove address_format configuration from template configs#955
DZakh merged 1 commit intomainfrom
claude/default-checksum-addresses-ae0t3

Conversation

@DZakh
Copy link
Member

@DZakh DZakh commented Feb 16, 2026

Summary

Removed the address_format configuration option and its associated comments from the ERC20 and Greeter template configuration files.

Changes

  • Removed address_format: lowercase configuration from erc20_template/typescript/config.yaml
  • Removed address_format: lowercase configuration from greeter_template/typescript/config.yaml
  • Removed explanatory comments about address format options ('checksum' vs 'lowercase') from both templates

Details

The address_format configuration and its documentation have been stripped from both template files. This suggests either:

  • The configuration option is no longer supported or needed
  • A default behavior has been established that makes explicit configuration unnecessary
  • The setting is now handled elsewhere in the codebase

https://claude.ai/code/session_0168y16Gw2hqSrZmoWJGLWNK

Summary by CodeRabbit

  • Chores
    • Simplified code generation templates by removing explicit address formatting configuration and associated documentation.

…ecksum

The greeter and erc20 templates explicitly set address_format: lowercase.
Removing the field lets the config parser default to checksum addresses,
which is the preferred default for new projects.

https://claude.ai/code/session_0168y16Gw2hqSrZmoWJGLWNK
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 16, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

The pull request removes address_format: lowercase configuration settings and their accompanying documentation comments from two TypeScript template configuration files in the code generator. No new settings or logic are introduced.

Changes

Cohort / File(s) Summary
TypeScript Template Configs
codegenerator/cli/templates/static/erc20_template/typescript/config.yaml, codegenerator/cli/templates/static/greeter_template/typescript/config.yaml
Removed address_format: lowercase setting and explanatory comments from both ERC20 and Greeter TypeScript config files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 A config line takes its final bow,
No more lowercase, only simplicity now,
Less to manage, less to keep,
Templates rest in silence deep. ✨

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title clearly and concisely summarizes the main change: removing address_format configuration from template configs, which matches the actual changes made to both ERC20 and Greeter template files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch claude/default-checksum-addresses-ae0t3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@DZakh DZakh requested a review from JonoPrest February 16, 2026 13:43
@DZakh DZakh merged commit 0b8ca83 into main Feb 16, 2026
2 checks passed
@DZakh DZakh deleted the claude/default-checksum-addresses-ae0t3 branch February 16, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants