Skip to content

Add failing .at(0).exists() test #1478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ljharb merged 2 commits into from
Jul 7, 2018
Merged

Add failing .at(0).exists() test #1478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bbd51b
[Tests] `shallow`: `.at()`: failing test for nonexistent element
KordonDev Jan 13, 2018
9739619
[Fix] `shallow`: `.at()`: return an empty wrapper when an index does …
ljharb Jul 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/enzyme-test-suite/test/ReactWrapper-spec.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3140,6 +3140,19 @@ describeWithDOM('mount', () => {
expect(wrapper.find('.bar').at(2).hasClass('bux')).to.equal(true);
expect(wrapper.find('.bar').at(3).hasClass('baz')).to.equal(true);
});

it('`.at()` does not affect the results of `.exists()`', () => {
const wrapper = mount((
<div>
<div className="foo" />
</div>
));
expect(wrapper.find('.bar').exists()).to.equal(false);
expect(wrapper.find('.bar').at(0).exists()).to.equal(false);

expect(wrapper.find('.foo').exists()).to.equal(true);
expect(wrapper.find('.foo').at(0).exists()).to.equal(true);
});
});

describe('.get(index)', () => {
Expand Down
13 changes: 13 additions & 0 deletions packages/enzyme-test-suite/test/ShallowWrapper-spec.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3091,6 +3091,19 @@ describe('shallow', () => {
expect(wrapper.find('.bar').at(2).hasClass('bux')).to.equal(true);
expect(wrapper.find('.bar').at(3).hasClass('baz')).to.equal(true);
});

it('`.at()` does not affect the results of `.exists()`', () => {
const wrapper = shallow((
<div>
<div className="foo" />
</div>
));
expect(wrapper.find('.bar').exists()).to.equal(false);
expect(wrapper.find('.bar').at(0).exists()).to.equal(false);

expect(wrapper.find('.foo').exists()).to.equal(true);
expect(wrapper.find('.foo').at(0).exists()).to.equal(true);
});
});

describe('.get(index)', () => {
Expand Down
6 changes: 5 additions & 1 deletion packages/enzyme/src/ReactWrapper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -919,7 +919,11 @@ class ReactWrapper {
* @returns {ReactWrapper}
*/
at(index) {
return this.wrap(this.getNodesInternal()[index]);
const nodes = this.getNodesInternal();
if (index < nodes.length) {
return this.wrap(nodes[index]);
}
return this.wrap([]);
}

/**
Expand Down
8 changes: 6 additions & 2 deletions packages/enzyme/src/ShallowWrapper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1116,7 +1116,7 @@ class ShallowWrapper {
* @returns {ReactElement}
*/
get(index) {
return getAdapter(this[OPTIONS]).nodeToElement(this.getNodesInternal()[index]);
return this.getElements()[index];
}

/**
Expand All @@ -1126,7 +1126,11 @@ class ShallowWrapper {
* @returns {ShallowWrapper}
*/
at(index) {
return this.wrap(this.getNodesInternal()[index]);
const nodes = this.getNodesInternal();
if (index < nodes.length) {
return this.wrap(nodes[index]);
}
return this.wrap([]);
}

/**
Expand Down