-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Detect Fiber types to avoid inlining constants #1790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| import React from 'react'; | ||
| import ReactDOM from 'react-dom'; | ||
|
|
||
| function getFiber(element) { | ||
| const container = global.document.createElement('div'); | ||
| let inst = null; | ||
| class Tester extends React.Component { | ||
| render() { | ||
| inst = this; | ||
| return element; | ||
| } | ||
| } | ||
| ReactDOM.render(React.createElement(Tester), container); | ||
| return inst._reactInternalFiber.child; | ||
| } | ||
|
|
||
| module.exports = function detectFiberTags() { | ||
| const supportsMode = typeof React.StrictMode !== 'undefined'; | ||
| const supportsContext = typeof React.createContext !== 'undefined'; | ||
| const supportsForwardRef = typeof React.forwardRef !== 'undefined'; | ||
|
|
||
| function Fn() { | ||
| return null; | ||
| } | ||
| // eslint-disable-next-line react/prefer-stateless-function | ||
| class Cls extends React.Component { | ||
| render() { | ||
| return null; | ||
| } | ||
| } | ||
| let Ctx = null; | ||
| let FwdRef = null; | ||
| if (supportsContext) { | ||
| Ctx = React.createContext(); | ||
| } | ||
| if (supportsForwardRef) { | ||
| // React will warn if we don't have both arguments. | ||
| // eslint-disable-next-line no-unused-vars | ||
| FwdRef = React.forwardRef((props, ref) => null); | ||
| } | ||
|
|
||
| return { | ||
| HostRoot: getFiber('test').return.return.tag, // Go two levels above to find the root | ||
| ClassComponent: getFiber(React.createElement(Cls)).tag, | ||
| Fragment: getFiber([['nested']]).tag, | ||
| FunctionalComponent: getFiber(React.createElement(Fn)).tag, | ||
| HostPortal: getFiber(ReactDOM.createPortal(null, global.document.createElement('div'))).tag, | ||
| HostComponent: getFiber(React.createElement('span')).tag, | ||
| HostText: getFiber('text').tag, | ||
| Mode: supportsMode | ||
| ? getFiber(React.createElement(React.StrictMode)).tag | ||
| : -1, | ||
| ContextConsumer: supportsContext | ||
| ? getFiber(React.createElement(Ctx.Consumer, null, () => null)).tag | ||
| : -1, | ||
| ContextProvider: supportsContext | ||
| ? getFiber(React.createElement(Ctx.Provider, { value: null })).tag | ||
| : -1, | ||
| ForwardRef: supportsForwardRef | ||
| ? getFiber(React.createElement(FwdRef)).tag | ||
| : -1, | ||
| }; | ||
| }; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These assume you're not going to use a newer
reactminor with an olderreact-domminor. If that's not an assumption we're comfortable making, I can add some try-catches and fall back.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that it's fine if things break with a mismatched react/react-dom - those have always had to match minor versions to work properly.