-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Invoke() api #1856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invoke() api #1856
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # `.invoke(propName)(...args) => Any` | ||
|
|
||
| Invokes a function prop. | ||
|
|
||
| #### Arguments | ||
|
|
||
| 1. `propName` (`String`): The function prop that is invoked | ||
| 2. `...args` (`Any` [optional]): Arguments that is passed to the prop function | ||
|
|
||
|
|
||
|
|
||
| #### Returns | ||
|
|
||
| `Any`: Returns the value from the prop function | ||
|
|
||
| #### Example | ||
|
|
||
| ```jsx | ||
| class Foo extends React.Component { | ||
| loadData() { | ||
| return fetch(); | ||
| } | ||
|
|
||
| render() { | ||
| return ( | ||
| <div> | ||
| <button | ||
| type="button" | ||
| onClick={() => this.loadData()} | ||
| > | ||
| Load more | ||
| </button> | ||
| </div> | ||
| ); | ||
| } | ||
| } | ||
| const wrapper = mount(<Foo />); | ||
| wrapper.find('a').invoke('onClick')().then(() => { | ||
| // expect() | ||
| }); | ||
| ``` |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| # `.invoke(invokePropName)(...args) => Any` | ||
|
|
||
| Invokes a function prop. | ||
|
|
||
| #### Arguments | ||
|
|
||
| 1. `propName` (`String`): The function prop that is invoked | ||
| 2. `...args` (`Any` [optional]): Arguments that is passed to the prop function | ||
|
|
||
| This essentially calls wrapper.prop(propName)(...args). | ||
|
|
||
| #### Returns | ||
|
|
||
| `Any`: Returns the value from the prop function | ||
|
|
||
| #### Example | ||
|
|
||
| ```jsx | ||
| class Foo extends React.Component { | ||
| loadData() { | ||
| return fetch(); | ||
| } | ||
|
|
||
| render() { | ||
| return ( | ||
| <div> | ||
| <button | ||
| type="button" | ||
| onClick={() => this.loadData()} | ||
| > | ||
| Load more | ||
| </button> | ||
| </div> | ||
| ); | ||
| } | ||
| } | ||
| const wrapper = shallow(<Foo />); | ||
| wrapper.find('a').invoke('onClick')().then(() => { | ||
| // expect() | ||
| }); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| import React from 'react'; | ||
| import { expect } from 'chai'; | ||
| import sinon from 'sinon-sandbox'; | ||
|
|
||
| export default function describeInvoke({ | ||
| Wrap, | ||
| WrapperName, | ||
| }) { | ||
| describe('.invoke(propName)(..args)', () => { | ||
| class CounterButton extends React.Component { | ||
| constructor(props) { | ||
| super(props); | ||
| this.state = { count: 0 }; | ||
| } | ||
|
|
||
| render() { | ||
| const { count } = this.state; | ||
| return ( | ||
| <div> | ||
| <button | ||
| type="button" | ||
| onClick={() => this.setState(({ count: oldCount }) => ({ count: oldCount + 1 }))} | ||
| > | ||
| {count} | ||
| </button> | ||
| </div> | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| class ClickableLink extends React.Component { | ||
| render() { | ||
| const { onClick } = this.props; | ||
| return ( | ||
| <div> | ||
| <a onClick={onClick}>foo</a> | ||
| </div> | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| it('throws when pointing to a non-function prop', () => { | ||
| const wrapper = Wrap(<div data-a={{}} />); | ||
|
|
||
| expect(() => wrapper.invoke('data-a')).to.throw( | ||
| TypeError, | ||
| `${WrapperName}::invoke() requires the name of a prop whose value is a function`, | ||
| ); | ||
|
|
||
| expect(() => wrapper.invoke('does not exist')).to.throw( | ||
| TypeError, | ||
| `${WrapperName}::invoke() requires the name of a prop whose value is a function`, | ||
| ); | ||
| }); | ||
|
|
||
| it('can update the state value', () => { | ||
| const wrapper = Wrap(<CounterButton />); | ||
| expect(wrapper.state('count')).to.equal(0); | ||
| wrapper.find('button').invoke('onClick')(); | ||
| expect(wrapper.state('count')).to.equal(1); | ||
| }); | ||
|
|
||
| it('can return the handlers’ return value', () => { | ||
| const sentinel = {}; | ||
| const spy = sinon.stub().returns(sentinel); | ||
|
|
||
| const wrapper = Wrap(<ClickableLink onClick={spy} />); | ||
|
|
||
| const value = wrapper.find('a').invoke('onClick')(); | ||
| expect(value).to.equal(sentinel); | ||
| expect(spy).to.have.property('callCount', 1); | ||
| }); | ||
|
|
||
| it('can pass in arguments', () => { | ||
| const spy = sinon.spy(); | ||
|
|
||
| const wrapper = Wrap(<ClickableLink onClick={spy} />); | ||
|
|
||
| const a = {}; | ||
| const b = {}; | ||
| wrapper.find('a').invoke('onClick')(a, b); | ||
| expect(spy).to.have.property('callCount', 1); | ||
| const [[arg1, arg2]] = spy.args; | ||
| expect(arg1).to.equal(a); | ||
| expect(arg2).to.equal(b); | ||
| }); | ||
| }); | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -827,6 +827,27 @@ class ReactWrapper { | |
| return this.props()[propName]; | ||
| } | ||
|
|
||
| /** | ||
| * Used to invoke a function prop. | ||
| * Will invoke an function prop and return its value. | ||
| * | ||
| * @param {String} propName | ||
| * @returns {Any} | ||
| */ | ||
| invoke(propName) { | ||
| return this.single('invoke', () => { | ||
| const handler = this.prop(propName); | ||
| if (typeof handler !== 'function') { | ||
| throw new TypeError('ReactWrapper::invoke() requires the name of a prop whose value is a function'); | ||
| } | ||
| return (...args) => { | ||
| const response = handler(...args); | ||
| this[ROOT].update(); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why is this needed?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @ljharb It's the same as what But I've covered the most case by this PR so this might be unnecessary. |
||
| return response; | ||
| }; | ||
| }); | ||
| } | ||
|
|
||
| /** | ||
| * Returns a wrapper of the node rendered by the provided render prop. | ||
| * | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1295,6 +1295,27 @@ class ShallowWrapper { | |
| return this.props()[propName]; | ||
| } | ||
|
|
||
| /** | ||
| * Used to invoke a function prop. | ||
| * Will invoke an function prop and return its value. | ||
| * | ||
| * @param {String} propName | ||
| * @returns {Any} | ||
| */ | ||
| invoke(propName) { | ||
| return this.single('invoke', () => { | ||
| const handler = this.prop(propName); | ||
| if (typeof handler !== 'function') { | ||
| throw new TypeError('ShallowWrapper::invoke() requires the name of a prop whose value is a function'); | ||
| } | ||
| return (...args) => { | ||
| const response = handler(...args); | ||
| this[ROOT].update(); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ditto |
||
| return response; | ||
| }; | ||
| }); | ||
| } | ||
|
|
||
| /** | ||
| * Returns a wrapper of the node rendered by the provided render prop. | ||
| * | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.