Skip to content

[SPARK-48849][SS]Create OperatorStateMetadataV2 for the TransformWithStateExec operator #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ericm-db wants to merge 22 commits into from
Closed

[SPARK-48849][SS]Create OperatorStateMetadataV2 for the TransformWithStateExec operator #13

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
4849f20
a base change a draft suite
jingz-db Jul 8, 2024
2bbd2ce
working version, will write test suites and test for composite types
jingz-db Jul 8, 2024
4f5185a
a suite with composite type, why key encoder spec overwritten
jingz-db Jul 8, 2024
00741ff
fix suites & add TTL suites
jingz-db Jul 9, 2024
3691a16
feedback
ericm-db Jul 9, 2024
0ad3679
creating operatorstatemetadata log
ericm-db Jun 27, 2024
ef86e37
removing ': Array[StateStoreMetadata]'
ericm-db Jun 27, 2024
06940c3
adding operatorProperties as a metadata column
ericm-db Jun 27, 2024
a668b77
changing the order of the metadata
ericm-db Jun 27, 2024
a057166
tests pass
ericm-db Jun 28, 2024
07ccd55
test case
ericm-db Jun 28, 2024
03265af
rebase
ericm-db Jul 1, 2024
22b8b0a
Feedback
ericm-db Jul 2, 2024
37392bf
files written correctly
ericm-db Jul 2, 2024
cbbd47f
tests minus purging
ericm-db Jul 2, 2024
81e1fb1
tests pass
ericm-db Jul 2, 2024
99609ee
tests pass
ericm-db Jul 3, 2024
77ffe95
hdfsmetadatalog
ericm-db Jul 3, 2024
6c90c9f
feedback
ericm-db Jul 4, 2024
b638592
checking the OperatorStateMetadata log for the state schema file
ericm-db Jul 8, 2024
58e1947
adding todo
ericm-db Jul 8, 2024
6ff37f4
removing println, test passes
ericm-db Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rebase
  • Loading branch information
@ericm-db
ericm-db committed Jul 9, 2024
commit 03265af43b1ba9b1566d7641cb829161d0d9b29d
3 changes: 2 additions & 1 deletion .../main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,8 @@ case class StreamingSymmetricHashJoinExec(
private val stateStoreNames =
SymmetricHashJoinStateManager.allStateStoreNames(LeftSide, RightSide)

override def operatorStateMetadata(): OperatorStateMetadata = {
override def operatorStateMetadata(
stateSchemaPaths: Array[String] = Array.empty): OperatorStateMetadata = {
val info = getStateInfo
val operatorInfo = OperatorInfoV1(info.operatorId, shortName)
val stateStoreInfo =
Expand Down
6 changes: 3 additions & 3 deletions ...core/src/main/scala/org/apache/spark/sql/execution/streaming/TransformWithStateExec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,14 +423,14 @@ case class TransformWithStateExec(
}

/** Metadata of this stateful operator and its states stores. */
override def operatorStateMetadata(): OperatorStateMetadata = {
override def operatorStateMetadata(
stateSchemaPaths: Array[String] = Array.empty): OperatorStateMetadata = {
val info = getStateInfo
val operatorInfo = OperatorInfoV1(info.operatorId, shortName)
// stateSchemaFilePath should be populated at this point
assert(info.stateSchemaPath.isDefined)
val stateStoreInfo =
Array(StateStoreMetadataV2(
StateStoreId.DEFAULT_STORE_NAME, 0, info.numPartitions, info.stateSchemaPath.get))
StateStoreId.DEFAULT_STORE_NAME, 0, info.numPartitions, stateSchemaPaths.head))

val operatorPropertiesJson: JValue =
("timeMode" -> JString(timeMode.toString)) ~
Expand Down
6 changes: 4 additions & 2 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,8 @@ trait StateStoreWriter extends StatefulOperator with PythonSQLMetrics { self: Sp
protected def timeTakenMs(body: => Unit): Long = Utils.timeTakenMs(body)._2

/** Metadata of this stateful operator and its states stores. */
def operatorStateMetadata(): OperatorStateMetadata = {
def operatorStateMetadata(
stateSchemaPaths: Array[String] = Array.empty): OperatorStateMetadata = {
val info = getStateInfo
val operatorInfo = OperatorInfoV1(info.operatorId, shortName)
val stateStoreInfo =
Expand Down Expand Up @@ -919,7 +920,8 @@ case class SessionWindowStateStoreSaveExec(
keyWithoutSessionExpressions, getStateInfo, conf) :: Nil
}

override def operatorStateMetadata(): OperatorStateMetadata = {
override def operatorStateMetadata(
stateSchemaPaths: Array[String] = Array.empty): OperatorStateMetadata = {
val info = getStateInfo
val operatorInfo = OperatorInfoV1(info.operatorId, shortName)
val stateStoreInfo = Array(StateStoreMetadataV1(
Expand Down