Skip to content

erts: Support cgroup2 CPU quotas #2922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2021
Merged

erts: Support cgroup2 CPU quotas #2922

merged 1 commit into from
Jan 15, 2021

Conversation

@jhogberg
Copy link
Contributor

@jhogberg jhogberg commented Dec 9, 2020

@jhogberg jhogberg added team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI labels Dec 9, 2020
@jhogberg jhogberg self-assigned this Dec 9, 2020
@jhogberg jhogberg force-pushed the john/erts/cgroup-v2-cpu-quota/OTP-17002 branch 2 times, most recently from a0cd2f4 to 7385055 Compare December 9, 2020 12:38
@tsloughter
Copy link
Contributor

tsloughter commented Dec 9, 2020

Awesome 👍

@jhogberg jhogberg removed the testing currently being tested, tag is used by OTP internal CI label Dec 11, 2020
@jhogberg jhogberg force-pushed the john/erts/cgroup-v2-cpu-quota/OTP-17002 branch from 7385055 to 760194a Compare December 11, 2020 09:32
@jhogberg jhogberg changed the base branch from master to maint December 11, 2020 09:33
@tianon tianon mentioned this pull request Dec 30, 2020
Merged
@jhogberg jhogberg added the testing currently being tested, tag is used by OTP internal CI label Jan 7, 2021
@jhogberg jhogberg merged commit f962031 into erlang:maint Jan 15, 2021
@lrascao
Copy link
Contributor

lrascao commented Jan 15, 2021

Does this mean we no longer need to override the number of available schedulers when running in a Kubernetes environment?

@jhogberg
Copy link
Contributor Author

jhogberg commented Jan 15, 2021

Yes.

@tsloughter
Copy link
Contributor

tsloughter commented Jan 15, 2021

@lrascao note that was already the case, so you don't need the future OTP-24 release to do this. The majority of users of kubernetes or docker are on cgroup v1. Docker just added support in version 20.10.

This will keep it working for a future where users start to move to cgroup v2 in Kubernetes though :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jhogberg jhogberg

Labels

team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jhogberg @tsloughter @lrascao