-
Notifications
You must be signed in to change notification settings - Fork 253
Making images more responsive #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull request to resize the images so that they will be a bit less gigantic
some GIF was just too big so I have made it smaller
Resizing image size
Make 1 GIF smaller
week06.md
Outdated
| [try in codepen](https://codepen.io/erluxman/pen/xxwJRBQ) | ||
|
|
||
|  | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empty line has inconsistency.. Please Use Markdown Linter.
If that is not the case, use a line above and below the tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will read about Markdown Linter.
| 2. ___`A lambda.`___ | ||
|
|
||
|  | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be it should be changed as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you referring to the image size?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant extra empty lines
week10.md
Outdated
| 2. Add `analysis_options.yaml` in project root directory. | ||
|  | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be here as well?
|
|
||
| [visit dough](https://pub.dev/packages/dough#-installing-tab-) | ||
|
|
||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this change if it looks good in real..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am sorry but I didn't understand what you meant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just replacing the md image tag with HTML image tag and not adding any extra empty lines or spaces.
|
So what is your intent? You want to change the dimension of every image or particular file only? If you want to change for all, you might not to spend some time on 😉 Please also, don't put unnecessary empty lines. |
|
@erluxman You want to change the dimension of every image or particular file only?. I wanted to help and give the images with a very large size smaller ( you have to scroll because the image does not fit well do the screen) don't put unnecessary empty lines - good point actually, I was mainly looking at the preview of the images and not how it looks in the text file - point taken. I will try to fix the problems soon and update my pr. |
README.md
Outdated
| We can type `stless` and `stful` and we get Autocomplete Suggestion to generate Stateless Flutter Widget or Stateful Flutter Widget Respectively. | ||
|
|
||
|  | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empty lines here
README.md
Outdated
| This is to encapsulate the inner function from everything else outside the outer function. | ||
|
|
||
|  | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empty line
README.md
Outdated
| Can be replaced with | ||
|
|
||
|  | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
empty line
README.md
Outdated
| try in [Dartpad](https://dartpad.dartlang.org/290e17306b745ed83b9242653ca55041) | ||
|
|
||
|  | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
empty line
README.md
Outdated
|
|
||
| ### `🚨❗️Caution❗️🚨` : **Your cursor should be inside the class that you want to generate data class.** | ||
| ### `🚨❗️Caution❗️🚨` | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You converted a single line heading into multiple and it won't show the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
week06.md
Outdated
| [play on codepen](https://codepen.io/erluxman/pen/PoPyNrM) | ||
|
|
||
|  | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here as well
| ) | ||
|
|
||
| [try in codepen](https://codepen.io/erluxman/pen/vYNQLPx) | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 empty lines here, 3 extra
| 2. ___`A lambda.`___ | ||
|
|
||
|  | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant extra empty lines
week07.md
Outdated
| [get the code](https://gist.github.com/erluxman/7b5c1dfec4461b147d9b00a86d080bb5) | ||
|
|
||
|  | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empty lines
week07.md
Outdated
|
|
||
|  | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ELS 😀
|
Except the above everything looks dope 😎 |
|
Thanks a lot for your contribution bro 🙏🏼 |

@erluxman this is the single pull request that you have asked for. All the image changes in one pr.