Skip to content

Conversation

@Tamir198
Copy link
Contributor

@erluxman this is the single pull request that you have asked for. All the image changes in one pr.

week06.md Outdated
[try in codepen](https://codepen.io/erluxman/pen/xxwJRBQ)

![animatedswitcher](assets/37animatedswitcher.gif)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty line has inconsistency.. Please Use Markdown Linter.

If that is not the case, use a line above and below the tag.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will read about Markdown Linter.

2. ___`A lambda.`___

![lambda](assets/45lambda.png)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be it should be changed as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you referring to the image size?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah..

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant extra empty lines

week10.md Outdated
2. Add `analysis_options.yaml` in project root directory.
![lint](assets/65lint.png)


Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be here as well?


[visit dough](https://pub.dev/packages/dough#-installing-tab-)

![dough](assets/91doughh.gif)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change if it looks good in real..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry but I didn't understand what you meant.

This is how it looks in real

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just replacing the md image tag with HTML image tag and not adding any extra empty lines or spaces.

@erluxman
Copy link
Owner

So what is your intent? You want to change the dimension of every image or particular file only?

If you want to change for all, you might not to spend some time on 😉

Please also, don't put unnecessary empty lines.

@Tamir198
Copy link
Contributor Author

@erluxman You want to change the dimension of every image or particular file only?.

I wanted to help and give the images with a very large size smaller ( you have to scroll because the image does not fit well do the screen)

don't put unnecessary empty lines - good point actually, I was mainly looking at the preview of the images and not how it looks in the text file - point taken.

I will try to fix the problems soon and update my pr.

README.md Outdated
We can type `stless` and `stful` and we get Autocomplete Suggestion to generate Stateless Flutter Widget or Stateful Flutter Widget Respectively.

![statful](assets/01stlesstful.gif)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty lines here

README.md Outdated
This is to encapsulate the inner function from everything else outside the outer function.

![functions](assets/03functions.png)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty line

README.md Outdated
Can be replaced with

![cascadeafter](assets/04cascadeafter.png)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty line

README.md Outdated
try in [Dartpad](https://dartpad.dartlang.org/290e17306b745ed83b9242653ca55041)

![cascade](assets/04cascadebefore.png)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty line

README.md Outdated

### `🚨❗️Caution❗️🚨` : **Your cursor should be inside the class that you want to generate data class.**
### `🚨❗️Caution❗️🚨`

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You converted a single line heading into multiple and it won't show the same

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

week06.md Outdated
[play on codepen](https://codepen.io/erluxman/pen/PoPyNrM)

![animatedicon](assets/40animatedicon.gif)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well

)

[try in codepen](https://codepen.io/erluxman/pen/vYNQLPx)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 empty lines here, 3 extra

2. ___`A lambda.`___

![lambda](assets/45lambda.png)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant extra empty lines

week07.md Outdated
[get the code](https://gist.github.com/erluxman/7b5c1dfec4461b147d9b00a86d080bb5)

![filters](assets/46colorfiltered.gif)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty lines

week07.md Outdated

![mask](assets/47mask.png)


Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ELS 😀

@erluxman
Copy link
Owner

Please navigate to files changed tab and make sure every change look like this without extra spaces.

Screen Shot 2020-08-20 at 7 15 30 AM

@Tamir198
Copy link
Contributor Author

Please navigate to files changed tab and make sure every change look like this without extra spaces.

Screen Shot 2020-08-20 at 7 15 30 AM

I have done it, removing every extra empty line.

Thank you for the tip, this looks better without the extra empty lines 🥇

@erluxman
Copy link
Owner

Except the above everything looks dope 😎

@erluxman erluxman merged commit 9fde875 into erluxman:master Aug 20, 2020
@erluxman
Copy link
Owner

Thanks a lot for your contribution bro 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants