-
-
Notifications
You must be signed in to change notification settings - Fork 33
feat: add no-property-in-node rule #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aladdin-add
merged 22 commits into
eslint-community:main
from
JoshuaKGoldberg:no-property-in-node
Feb 6, 2024
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
b9d6c28
feat: add no-property-in-node rule
JoshuaKGoldberg 8cfaf6d
Add ☑️ emoji for recommended-type-checked
JoshuaKGoldberg 4d163e1
tests: valid before invalid
JoshuaKGoldberg d62539d
Also check for whether the node has a 'type'
JoshuaKGoldberg 3575644
Added docs and example to isAstNodeType
JoshuaKGoldberg e42c075
Expanded rule details
JoshuaKGoldberg 2a94dcb
Add more valid test cases
JoshuaKGoldberg 4d5d332
Merge branch 'main'
JoshuaKGoldberg 755cc08
Fixed test path to fixtures
JoshuaKGoldberg d76b08a
Use parserOptions.project: true for eslint-remote-tester on TS files
JoshuaKGoldberg 5913127
nit: avoid shadowing name for typePart
JoshuaKGoldberg d45695d
<!-- omit from toc -->
JoshuaKGoldberg 532925d
Downgraded to typescript-eslint@v5
JoshuaKGoldberg 6b60ab0
Also remove @typescript-eslint/utils
JoshuaKGoldberg 89aafda
Or rather, make @typescript-eslint/utils a -D
JoshuaKGoldberg 1d570e8
Remove ts-api-utils too
JoshuaKGoldberg 1ec0c2a
Removed recommended-type-checked
JoshuaKGoldberg de370b0
Removed README.md section too
JoshuaKGoldberg 18b205a
Removed eslint-remote-tester.config.js parserOptions.project too
JoshuaKGoldberg 8d68dc9
Redid README.md presets table
JoshuaKGoldberg d8dc1a0
Added all-type-checked
JoshuaKGoldberg d8cc468
Removed file notice
JoshuaKGoldberg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
<!-- omit from toc -->
- Loading branch information
commit d45695d3d3dcaf01540c0049fb65eeb4cef8939f
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.