fix: detect prefixed @keyframes
in no-duplicate-keyframe-selectors
#251
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What rule do you want to change?
no-duplicate-keyframe-selectors
What change do you want to make?
Generate more warnings
How do you think the change should be implemented?
A new default behavior
Example code
What does the rule currently do for this code?
It only detects duplicate keyframe selectors in unprefixed
@keyframes
blocks. Prefixed blocks like@-webkit-keyframes
,@-moz-keyframes
, or@-o-keyframes
are ignored, so duplicates there are not reported.What will the rule do after it's changed?
It will also detect duplicate keyframe selectors in vendor-prefixed
@keyframes
blocks, ensuring duplicates are reported consistently across prefixed and unprefixed animations.What changes did you make? (Give an overview)
Atrule
matchers (enter/exit) to use:/^(-(o|moz|webkit)-)?keyframes$/i
Related Issues
Is there anything you'd like reviewers to focus on?