refactor: migrate to ESLint v9 #76
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumirlumir
force-pushed
the
refactor-migrate-to-eslint-v9
branch
from
b24b643 to
dd66af8
Compare
lumirlumir
commented
Sep 18, 2025
| "require-unicode-regexp": "off", | ||
| "regexp/optimal-quantifier-concatenation": "off", | ||
| "n/no-process-exit": "off", | ||
| "n/no-unsupported-features/es-syntax": "off", |
There was a problem hiding this comment.
It appears that hashbang is not supported in Node.js v10.
I'm not sure what the best approach would be here, so I've disabled it for now.
There was a problem hiding this comment.
I prepared a PR to drop node.js <18: #77
lumirlumir
commented
Sep 18, 2025
Comment on lines
+13
to
+14
| "require-unicode-regexp": "off", | ||
| "regexp/optimal-quantifier-concatenation": "off", |
There was a problem hiding this comment.
It seems that updating the regex may not be appropriate here given the formal .eslintrc.yml setup, so I’ve turned it off.
Line 8 in f975c63
lumirlumir
commented
Sep 18, 2025
| uses: actions/setup-node@v5 | ||
| with: | ||
| node-version: '12.x' | ||
| node-version: '22.x' |
There was a problem hiding this comment.
The CI only runs the lint script, and ESLint v9 requires Node.js 18 or newer, so I've set it to Node.js 22.
|
I'm marking this as a draft until #77 is resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
In this PR, I've migrated to ESLint v9.
It seems that it's been a while since the ESLint configuration was last updated.
I've referenced the CommonJS setup in the following link:
https://github.com/eslint/eslint-github-bot/blob/main/eslint.config.js
I've only updated the JavaScript code that was reported by the new rules.
What changes did you make? (Give an overview)
In this PR, I've migrated to ESLint v9.
Related Issues
Ref: #75, #72
Is there anything you'd like reviewers to focus on?
N/A