chore: add @cfworker/json-schema to fix CI
#312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumirlumir
approved these changes
Nov 6, 2025
Member
lumirlumir
left a comment
lumirlumir
left a comment
There was a problem hiding this comment.
LGTM, thanks!
I've tried other approaches, but this seems the most reasonable way to fix the CI for now.
Would like one more check from the team before merging.
lumirlumir
changed the title
@cfworker/json-schema@cfworker/json-schema to fix CI
1 task
github-project-automation
bot
moved this from Second Review Needed
to Complete
in Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
This pull request fixes CI failures caused by
@modelcontextprotocol/[email protected]exporting type definitions that reference@cfworker/json-schema. Since that package is only declared as an optional peer dependency in the SDK, it is not installed automatically, which leads to the following TypeScript error:What changes did you make? (Give an overview)
I added
@cfworker/json-schematodevDependenciesso the type import can be resolved during the build.Related Issues
https://github.com/eslint/rewrite/actions/runs/19061914344/job/54443304560
https://github.com/eslint/rewrite/actions/runs/19113488111/job/54616379148
Is there anything you'd like reviewers to focus on?