Skip to content

Conversation

@fasttime
Copy link
Member

@fasttime fasttime commented Nov 8, 2025

Prerequisites checklist

What is the purpose of this pull request?

  • Fix and update the npm script test:types.
  • Update "Test Types" CI job.

What changes did you make? (Give an overview)

  • Updated the npm script test:types to run type tests in all packages. This script is only run locally.
  • Updated the CI workflow to run npx tsc when testing types. This is to catch type problems in packages without type tests.
  • Added @ts-ignore comments to fix an issue with missing type definitions in migrate-config.

Related Issues

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Nov 8, 2025
@fasttime fasttime marked this pull request as ready for review November 8, 2025 15:33
@lumirlumir lumirlumir moved this from Needs Triage to Triaging in Triage Nov 9, 2025
Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lumirlumir lumirlumir merged commit 0897d95 into main Nov 9, 2025
25 checks passed
@lumirlumir lumirlumir deleted the fix-npm-test-types branch November 9, 2025 08:02
@github-project-automation github-project-automation bot moved this from Triaging to Complete in Triage Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

3 participants