Skip to content

Conversation

@lumirlumir
Copy link
Member

@lumirlumir lumirlumir commented Nov 12, 2025

Prerequisites checklist

What is the purpose of this pull request?

In this PR, I've resolved the issue metioned in #314.

I've tested the change in my forked repository: https://github.com/lumirlumir/fork-rewrite

The PR to bump the eslint dependency was created successfully:

lumirlumir#3

image

lumirlumir#2

image

What changes did you make? (Give an overview)

In this PR, I've resolved the issue metioned in #314.

Related Issues

Fixes: #314

Is there anything you'd like reviewers to focus on?

FYI, matchDepsTypes option: https://docs.renovatebot.com/configuration-options/#matchdeptypes

image

@lumirlumir lumirlumir marked this pull request as ready for review November 12, 2025 14:26
@lumirlumir lumirlumir requested a review from nzakas November 12, 2025 14:26
@aladdin-add
Copy link
Member

What do you think about moving this config to eslint-base? Although only this package's dependencies currently include eslint, there may be more in the future. Doing this would prevent this issue from recurring.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aladdin-add that sounds like a good idea. Let's get this merged so we can update this package and also add to eslint-base.

@nzakas nzakas merged commit acfeed1 into main Nov 14, 2025
25 checks passed
@nzakas nzakas deleted the ci-update-eslint-in-mcp branch November 14, 2025 15:47
@github-project-automation github-project-automation bot moved this from Needs Triage to Complete in Triage Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

Change Request: Update ESLint in eslint/mcp

4 participants