Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Conversation

@MabezDev
Copy link
Member

@MabezDev MabezDev commented Jul 18, 2023

This PR adds transport detection and a InputIO implementation for the USB-SERIAL-JTAG driver.

Currently, draft because the usb serial jtag interrupt is not firing on the esp32s3 see esp-rs/esp-hal#633.

@MabezDev MabezDev marked this pull request as ready for review July 20, 2023 13:09
@MabezDev MabezDev requested a review from jessebraham July 20, 2023 13:10
@MabezDev
Copy link
Member Author

esp-rs/esp-hal#664 has resolved the esp32s3 issues. This is now ready for review.

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few nit-picky little comments, up to you whether to address them now or later, but overall LGTM! Thanks for all your work on this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants