Skip to content

Conversation

@har7an
Copy link
Contributor

@har7an har7an commented Aug 3, 2022

which was just recently stabilized in rust 1.62.0 and hence raises
the MSRV to 1.62.0 for all HALs. Use bool::then instead, which takes a
closure instead of a parameter but has the same effect otherwise and is
available since rust 1.50.0.

Fixes #131

which was just [recently stabilized in rust 1.62.0][1] and hence raises
the MSRV to 1.62.0 for all HALs. Use `bool::then` instead, which takes a
closure instead of a parameter but has the same effect otherwise and is
available [since rust 1.50.0][2].

[1]: rust-lang/rust#96628
[2]: https://doc.rust-lang.org/stable/std/primitive.bool.html#method.then
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you! I guess we're not actually verifying MSRV in CI, so I'm working on adding that now as well to avoid this in the future.

@jessebraham jessebraham merged commit 525c605 into esp-rs:main Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MSRV mismatch

2 participants