Skip to content

Add self-testing mode for TWAI peripheral. #1929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
playfulFence merged 6 commits into from
Aug 12, 2024
Merged

Add self-testing mode for TWAI peripheral. #1929

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
41485ac
Add self-testing mode for `TWAI` peripheral
playfulFence Aug 12, 2024
699c282
changelog entry
playfulFence Aug 12, 2024
a48d361
fix docs build
playfulFence Aug 12, 2024
e0c7c6e
fix async example
playfulFence Aug 12, 2024
6c302ec
Restore example to original state
playfulFence Aug 12, 2024
28b9088
`NoAck` -> `SelfTest`
playfulFence Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
NoAck -> SelfTest
  • Loading branch information
@playfulFence
playfulFence committed Aug 12, 2024
commit 28b908820892be71867f5243827cb832632082af
6 changes: 3 additions & 3 deletions esp-hal/src/twai/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@
//! can_rx_pin,
//! &clocks,
//! CAN_BAUDRATE,
//! TwaiMode::NoAck
//! TwaiMode::SelfTest
//! );
//!
//! // Partially filter the incoming messages to reduce overhead of receiving
Expand Down Expand Up @@ -249,7 +249,7 @@ pub enum TwaiMode {
Normal,
/// Self-test mode (no acknowledgement required for a successful message
/// transmission)
NoAck,
SelfTest,
/// Listen only operating mode
ListenOnly,
}
Expand Down Expand Up @@ -758,7 +758,7 @@ where
TwaiMode::Normal => {
// Do nothing special, the default state is Normal mode.
}
TwaiMode::NoAck => {
TwaiMode::SelfTest => {
// Set the self-test mode (no acknowledgement required)
T::register_block()
.mode()
Expand Down
2 changes: 1 addition & 1 deletion examples/src/bin/twai.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ fn main() -> ! {

// Begin configuring the TWAI peripheral. The peripheral is in a reset like
// state that prevents transmission but allows configuration.
// For self-testing use `NoAck` mode of the TWAI peripheral.
// For self-testing use `SelfTest` mode of the TWAI peripheral.
let mut can_config = twai::TwaiConfiguration::new_no_transceiver(
peripherals.TWAI0,
can_tx_pin,
Expand Down