Skip to content

Refactor SPI tests & re-enable S3 and some S2 #1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jessebraham merged 5 commits into from
Aug 26, 2024
Merged

Refactor SPI tests & re-enable S3 and some S2 #1990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0d7ad38
Deduplicate spi_full_duplex_dma_async
bugadani Aug 23, 2024
cfa74f4
Refactor SPI tests
bugadani Aug 23, 2024
d698140
Separate out PCNT tests
bugadani Aug 23, 2024
49a3864
Re-enable test on S3
bugadani Aug 23, 2024
fe09462
Re-enable some S2 tests
bugadani Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions hil-test/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,10 @@ harness = false
name = "spi_full_duplex_dma_async"
harness = false

[[test]]
name = "spi_full_duplex_dma_pcnt"
harness = false

[[test]]
name = "spi_half_duplex_read"
harness = false
Expand Down
24 changes: 9 additions & 15 deletions hil-test/tests/spi_full_duplex.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,15 @@ struct Context {
spi: Spi<'static, esp_hal::peripherals::SPI2, FullDuplexMode>,
}

impl Context {
pub fn init() -> Self {
#[cfg(test)]
#[embedded_test::tests]
mod tests {
use defmt::assert_eq;

use super::*;

#[init]
fn init() -> Context {
let peripherals = Peripherals::take();
let system = SystemControl::new(peripherals.SYSTEM);
let clocks = ClockControl::boot_defaults(system.clock_control).freeze();
Expand All @@ -49,19 +56,6 @@ impl Context {

Context { spi }
}
}

#[cfg(test)]
#[embedded_test::tests]
mod tests {
use defmt::assert_eq;

use super::*;

#[init]
fn init() -> Context {
Context::init()
}

#[test]
#[timeout(3)]
Expand Down
Loading