Skip to content

Remove the need to manually pass clocks around #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bugadani merged 8 commits into from
Sep 4, 2024
Merged

Remove the need to manually pass clocks around #1999

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
99e39ef
Clean up passing clocks to drivers
bugadani Sep 4, 2024
c586fc1
Update changelog
bugadani Sep 4, 2024
3cd5177
Initialise Clocks in a critical section
bugadani Sep 2, 2024
a221cab
Fix calling now() before init
bugadani Sep 3, 2024
5c2018e
Fix doc
bugadani Sep 3, 2024
4eea75e
Fix esp-wifi migration guide
bugadani Sep 3, 2024
87c4cdb
Add safety comment
bugadani Sep 4, 2024
f21f08d
Update tests
bugadani Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update tests
  • Loading branch information
@bugadani
bugadani committed Sep 4, 2024
commit f21f08d32cc7aed67b0c6194af450f8cbbdb7761
2 changes: 1 addition & 1 deletion hil-test/tests/gpio.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ mod tests {

let (gpio1, gpio2) = hil_test::common_test_pins!(io);

let timg0 = TimerGroup::new(peripherals.TIMG0, &clocks);
let timg0 = TimerGroup::new(peripherals.TIMG0);
esp_hal_embassy::init(timg0.timer0);

Context {
Expand Down
4 changes: 2 additions & 2 deletions hil-test/tests/i2c.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,14 @@ mod tests {

#[init]
fn init() -> Context {
let (peripherals, clocks) = esp_hal::init(esp_hal::Config::default());
let peripherals = esp_hal::init(esp_hal::Config::default());
let io = Io::new(peripherals.GPIO, peripherals.IO_MUX);

let (sda, scl) = hil_test::i2c_pins!(io);

// Create a new peripheral object with the described wiring and standard
// I2C clock speed:
let i2c = I2C::new(peripherals.I2C0, sda, scl, 100.kHz(), &clocks);
let i2c = I2C::new(peripherals.I2C0, sda, scl, 100.kHz());

Context { i2c }
}
Expand Down