Skip to content

Implement embedded_hal_async::delay::DelayNs for TIMGx timers #2084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JurajSadel merged 18 commits into from
Sep 24, 2024
+406 −11
Merged

Implement embedded_hal_async::delay::DelayNs for TIMGx timers #2084

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
910fc8f
Update `hil-test` package dependencies, add simple test for async del…
jessebraham Sep 4, 2024
5e86f82
Implement `embedded_hal_async::delay::DelayNs` for the `TIMGx` timers
jessebraham Sep 4, 2024
3334ab2
Improve tests slightly
jessebraham Sep 4, 2024
fc18ca4
Update `CHANGELOG.md`
jessebraham Sep 4, 2024
4ea585e
Enable `delay` and `delay_async` tests for the ESP32-H2
jessebraham Sep 6, 2024
b6326a7
Fix error in `delay_async` test after rebasing
jessebraham Sep 6, 2024
7da5d32
ESP32 does not have `SYSTIMER`, so don't try to test it :)
jessebraham Sep 6, 2024
23f1070
Protect int_ena modifications with INT_ENA_LOCK, clear int_clr in ISR…
JurajSadel Sep 17, 2024
8a1a514
Fix wrong imports
JurajSadel Sep 18, 2024
561be21
Address reviews: Remove duplicated/useless code and add HIL test for …
JurajSadel Sep 18, 2024
f1b3547
Implement DelayNs on Target instead of Periodic
JurajSadel Sep 20, 2024
dc837d4
clean dead code
JurajSadel Sep 20, 2024
26f57b6
fix after rebase
JurajSadel Sep 20, 2024
63ecba0
fix build errors
JurajSadel Sep 20, 2024
30fba69
More accurate nanos to ticks calculation
JurajSadel Sep 23, 2024
7243055
Fix wrong handler passed to set_interrupt_handler()
JurajSadel Sep 23, 2024
f78e5b7
Update esp-hal/src/timer/timg.rs
JurajSadel Sep 24, 2024
ba297de
cleanup left over
JurajSadel Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix after rebase
  • Loading branch information
@JurajSadel
JurajSadel committed Sep 24, 2024
commit 26f57b6c2cf3fb4a6a5dfb41443d38e0bf149dad
8 changes: 4 additions & 4 deletions esp-hal/src/timer/timg.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1195,7 +1195,7 @@ mod asynch {
// well.
#[handler]
pub(crate) fn timg0_timer0_handler() {
lock(&INT_ENA_LOCK, || {
lock(&INT_ENA_LOCK[0], || {
unsafe { &*crate::peripherals::TIMG0::PTR }
.int_ena()
.modify(|_, w| w.t(0).clear_bit())
Expand All @@ -1211,7 +1211,7 @@ mod asynch {
#[cfg(timg1)]
#[handler]
pub(crate) fn timg1_timer0_handler() {
lock(&INT_ENA_LOCK, || {
lock(&INT_ENA_LOCK[1], || {
unsafe { &*crate::peripherals::TIMG1::PTR }
.int_ena()
.modify(|_, w| w.t(0).clear_bit())
Expand All @@ -1226,7 +1226,7 @@ mod asynch {
#[cfg(timg_timer1)]
#[handler]
pub(crate) fn timg0_timer1_handler() {
lock(&INT_ENA_LOCK, || {
lock(&INT_ENA_LOCK[0], || {
unsafe { &*crate::peripherals::TIMG0::PTR }
.int_ena()
.modify(|_, w| w.t(1).clear_bit())
Expand All @@ -1241,7 +1241,7 @@ mod asynch {
#[cfg(all(timg1, timg_timer1))]
#[handler]
pub(crate) fn timg1_timer1_handler() {
lock(&INT_ENA_LOCK, || {
lock(&INT_ENA_LOCK[1], || {
unsafe { &*crate::peripherals::TIMG1::PTR }
.int_ena()
.modify(|_, w| w.t(1).clear_bit())
Expand Down