Skip to content

Conversation

@bugadani
Copy link
Contributor

@bugadani bugadani commented Sep 6, 2024

This PR merges the different touch macros, which also enables implementing the Touch trait directly - uncovering two missing pins.

@bugadani bugadani added the skip-changelog No changelog modification needed label Sep 6, 2024
@bugadani bugadani marked this pull request as ready for review September 6, 2024 15:17
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JurajSadel JurajSadel enabled auto-merge September 9, 2024 09:52
@JurajSadel JurajSadel added this pull request to the merge queue Sep 9, 2024
Down,
}

/// RTC input pin mode
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're these unused before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apparently not

Merged via the queue into esp-rs:main with commit 05941cc Sep 9, 2024
@bugadani bugadani deleted the touch branch September 9, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog No changelog modification needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants