-
Notifications
You must be signed in to change notification settings - Fork 367
PARL_IO: fix for garbage output at the start of some TX operations #2211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can we test this somehow, like counting expected number of edges with PCNT if the problem is reproducible with narrower outputs? |
I think thats possible, if we use the valid output and count clocks when valid is high. (thats how I finally isolated it). I'll give that a try. |
|
Added tests. Interestingly the error only happens in async, I added tests for both sync and async for both 8bit and 16bit |
|
Oh - the H2 has only 8 bit PARL_IO! |
|
So the |
|
No idea why the |
Don't worry about it |
JurajSadel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
1869bd6 to
f656a83
Compare
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
When starting a TX transfer using the PARL_IO peripheral the TX clock was disabled and re-enabled at the start of
start_write_bytes_dma. The TRM says that the clock should be re-enabled aftertx_start.Testing