Skip to content

Reimplement blocking trait for async i2c #2343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jessebraham merged 1 commit into from
Oct 14, 2024
Merged

Reimplement blocking trait for async i2c #2343

jessebraham merged 1 commit into from
Oct 14, 2024

Conversation

@bugadani
Copy link
Contributor

@bugadani bugadani commented Oct 12, 2024

Closes #2342

Dominaezzz
Dominaezzz approved these changes Oct 12, 2024
View reviewed changes
Copy link
Collaborator

@Dominaezzz Dominaezzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jessebraham
jessebraham approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jessebraham jessebraham added this pull request to the merge queue Oct 14, 2024
Merged via the queue into esp-rs:main with commit ef7842f Oct 14, 2024
@bugadani bugadani deleted the i2c branch October 14, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jessebraham jessebraham jessebraham approved these changes

@Dominaezzz Dominaezzz Dominaezzz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

embedded_hal::i2c::I2c no longer implemented for async I2c in esp-hal 0.21

3 participants

@bugadani @jessebraham @Dominaezzz