-
Notifications
You must be signed in to change notification settings - Fork 369
Include ROM API symbols #2374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include ROM API symbols #2374
Conversation
jessebraham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, thanks for taking care of this!
To be fair I'm pretty sure that "No need to include |
mhhhh - but that applies to esp-wifi not esp-hal (and it's mentioned in esp-wifi's changelog) |
|
But the migration guide you edited applies to esp-hal 🙃 |
oops - yeah that's the wrong crate |
|
|
a29bae3 to
2023458
Compare
MabezDev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
Since users seem to struggle with including the
rom_functions.xfrom esp-wifi we now include everything needed in esp-hal which shouldn't hurt. Hopefully also the process of updating is a bit easier now.Once this PR landed there will be a follow up PR to remove the linker scripts from esp-wifi-sys.
skip-changelogbecause of changes in esp-halTesting
Examples still work