Implement UART type erasure #2381
Conversation
bugadani
force-pushed
the
erase-uart
branch
3 times, most recently
from
40da306 to
5c4c0f3
Compare
bugadani
force-pushed
the
erase-uart
branch
5 times, most recently
from
1ce8234 to
e3aad0c
Compare
|
|
bugadani
force-pushed
the
erase-uart
branch
4 times, most recently
from
f67b298 to
0657965
Compare
| fn interrupt() -> Interrupt; | ||
| fn interrupt(&self) -> Interrupt; | ||
|
|
||
| #[doc(hidden)] |
There was a problem hiding this comment.
Not really related but ....
I wonder if we should doc-hide all those Instance/RegisterAccess traits 🤔
We do for some peripherals (e.g. I2c) but for most we don't - however it's something that would be just confusing to users in best case
There was a problem hiding this comment.
In the long run, I want to split out the RegisterBlock/signal part of the trait, and make it public. The rest (i.e. the actual driver implementations) will I think remain private. I'm hiding these things mostly as an "under construction" sign.
bjoernQ
left a comment
bjoernQ
left a comment
There was a problem hiding this comment.
LGTM - feel free to think about doc-hiding the Instance trait or merge as is
|
Are we fine with me disabling LTO in the test suite? |
What would be the alternative? |
|
Figuring out what's wrong, fixing the compiler and holding off the PR until the fix is released 😅 |
3 participants
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra: