[DMA 1/N] Add mode to DMA channel drivers #2519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
force-pushed
the
dma-mode
branch
7 times, most recently
from
5b89010 to
b901bd6
Compare
bugadani
commented
Nov 12, 2024
Dominaezzz
reviewed
Nov 12, 2024
Dominaezzz
reviewed
Nov 12, 2024
This comment was marked as outdated.
This comment was marked as outdated.
bugadani
changed the title
bugadani
force-pushed
the
dma-mode
branch
2 times, most recently
from
45b74c8 to
1990754
Compare
Dominaezzz
approved these changes
Nov 13, 2024
Collaborator
Dominaezzz
left a comment
Dominaezzz
left a comment
There was a problem hiding this comment.
Besides the burst thing, it looks like the behavior is overall the same.
Comment on lines
+2228
to
+2229
| fn peripheral_interrupt(&self) -> Option<Interrupt>; | ||
| fn async_handler(&self) -> Option<InterruptHandler>; |
Collaborator
There was a problem hiding this comment.
Long term I think these should be #[cfg]s rather than Options, as it makes it easier to grok what's really happening.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
This PR adds
Modetype parameters toChannelRxandChannelTx, so that in the future we can independently configure them between blocking and async modes. The PR also swaps the Mode and DMA chanel type params ofChannel, so that it is consistent with other peripherals - even if we apply different rules to DMA instance typing.