Skip to content

Fix UART unlisten calls so they clear the interrupt enable #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bjoernQ merged 1 commit into from
Nov 14, 2022
Merged

Fix UART unlisten calls so they clear the interrupt enable #261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix UART unlisten calls so they clear the interrupt enable bit instea… 
…d of setting it
  • Loading branch information
@raiker
raiker committed Nov 13, 2022
commit 5523a7b8b90c2873c552ab2fb10c83f7912b5405
6 changes: 3 additions & 3 deletions esp-hal-common/src/serial.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ where
self.uart
.register_block()
.int_ena
.modify(|_, w| w.at_cmd_char_det_int_ena().set_bit());
.modify(|_, w| w.at_cmd_char_det_int_ena().clear_bit());
}

/// Listen for TX-DONE interrupts
Expand All @@ -377,7 +377,7 @@ where
self.uart
.register_block()
.int_ena
.modify(|_, w| w.tx_done_int_ena().set_bit());
.modify(|_, w| w.tx_done_int_ena().clear_bit());
}

/// Listen for RX-FIFO-FULL interrupts
Expand All @@ -393,7 +393,7 @@ where
self.uart
.register_block()
.int_ena
.modify(|_, w| w.rxfifo_full_int_ena().set_bit());
.modify(|_, w| w.rxfifo_full_int_ena().clear_bit());
}

/// Checks if AT-CMD interrupt is set
Expand Down