Skip to content

Detangle I2C clock calculation #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MabezDev merged 2 commits into from
Nov 16, 2022
Merged

Detangle I2C clock calculation #263

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97a98a2
Detangle I2C clock calculation
bjoernQ Nov 15, 2022
b48e77a
Converted NOTE to FIXME
bjoernQ Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Converted NOTE to FIXME
  • Loading branch information
@bjoernQ
bjoernQ committed Nov 16, 2022
commit b48e77a6d904572f8aa4b976a3755a1d0c0f08dd
3 changes: 2 additions & 1 deletion esp-hal-common/src/i2c.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,7 @@ pub trait Instance {
.modify(|_, w| w.ref_always_on().set_bit());

// Configure filter
// FIXME if we ever change this we need to adapt `set_frequency` for ESP32
self.set_filter(Some(7), Some(7));

// Configure frequency
Expand Down Expand Up @@ -465,7 +466,7 @@ pub trait Instance {
// In the "worst" case, we will subtract 13, make sure the result will still be
// correct

// NOTE since we always set the filter threshold to 7 we don't need conditional code here
// FIXME since we always set the filter threshold to 7 we don't need conditional code here
// once that changes we need the conditional code here
scl_high -= 7 + 6;

Expand Down