Skip to content

Conversation

@MabezDev
Copy link
Member

  • It was easy to use the wrong type when writing a driver in esp-hal-common
  • Now the pac is completely hidden, but its internals are exposed crate-wide via peripherals.

Quite a noisy pr so we may want to merge this once the current peripheral ref pr's are merged, and make sure everyone does a rebase after.

@MabezDev MabezDev force-pushed the completely-hide-pac branch 2 times, most recently from 3e60cd1 to 8477981 Compare December 14, 2022 09:39
jessebraham and others added 2 commits December 14, 2022 13:24
* Add SHA to list of peripherals to be created

* Refactor SHA peripheral to use PeripheralRef

* Update SHA examples to get them building again
@MabezDev MabezDev force-pushed the completely-hide-pac branch from 1e57870 to 36857a7 Compare December 14, 2022 12:24
@MabezDev MabezDev merged commit 3a57eb9 into main Dec 14, 2022
@MabezDev MabezDev deleted the completely-hide-pac branch January 9, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants