Skip to content

Only set the set_suc_eof flag on the last item #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bjoernQ merged 1 commit into from
Jan 24, 2023
Merged

Only set the set_suc_eof flag on the last item #359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion esp-hal-common/src/dma/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,7 @@ pub(crate) mod private {

let mut dw0 = &mut descriptors[descr];

dw0.set_suc_eof(true);
dw0.set_suc_eof(last);
dw0.set_owner(Owner::Dma);
dw0.set_size(chunk_size as u16); // align to 32 bits?
dw0.set_length(chunk_size as u16); // actual size of the data!?
Expand Down