Skip to content

Conversation

@i404788
Copy link
Contributor

@i404788 i404788 commented Feb 27, 2023

Although this component is now mostly complete it's untested and not very safe (read: intuitive to use). Feel free to bring ideas on how it could be improved, but given the relative complexity of the operator dead-time module we might just need to refer people to the technical reference manual for non-trivial use-cases.

Potential toods:

  • Allow configuration update method (6:3, 3:0) of FED/RED registers
  • Clarify/Type clock selection
  • Update PACs to avoid unsafe casting
  • Add more pre-made configuration

@jessebraham
Copy link
Member

Thanks for your contribution! Do you have any plans to continue this work, or am I able to close this PR?

@i404788
Copy link
Contributor Author

i404788 commented Jul 21, 2023

Hey, I do intent to add FED/RED update functions but it's mostly complete already (seems to build locally on all devices). The interface is not as intuitive as I think it could be but this is a very hard problem due to the large configuration space.

@i404788 i404788 marked this pull request as ready for review July 22, 2023 22:26
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this branch updated, I think it looks good. Due to the complexity of the overall problem I see no issue merging this as-is, nothing is set in stone and we can continue to iterate on the API as needed.

@jessebraham jessebraham merged commit d4f5afa into esp-rs:main Jul 24, 2023
@jessebraham
Copy link
Member

If there are any additional features you feel are important relating to this, or anything that you feel should be fixed, I would appreciate if you could open an issue just so that's it's documented somewhere please!

playfulFence pushed a commit to playfulFence/esp-hal that referenced this pull request Sep 26, 2023
* Add Initial MCPWM DeadTime configuration

* Add option to use other channel for action trigger

* Fix build for non-esp32s3 (register name difference)

* Fix changelog build & add a way to update RED/FED after construction

* Fix regs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants