Move rwtext after other RAM data sections #464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JurajSadel
approved these changes
Mar 31, 2023
Contributor
JurajSadel
left a comment
JurajSadel
left a comment
There was a problem hiding this comment.
LGTM, thank you! The rtc_watchdog and bunch of other random examples I tried work fine for me,
i404788
pushed a commit
to i404788/esp-hal
that referenced
this pull request
Jul 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have to admit, I'm not entirely sure why this works, but I do know the ordering of some sections matters so I guess that's it. I ran all the other examples for the C6 to check for regressions, and the rest still worked.
I also added some gitignore updates because I'm really really tired of having to remember the debug & wokwi configurations :D, let me know if this is an issue though and I'll remove it.
Closes #462