Skip to content

Use 192 as mclk_multiple for 24-bit I2S #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bjoernQ merged 1 commit into from
Apr 8, 2023
Merged

Use 192 as mclk_multiple for 24-bit I2S #471

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion esp-hal-common/src/i2s.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1978,7 +1978,9 @@ mod private {
//
// main difference is we are using fixed-point arithmetic here

let mclk_multiple = 256;
// If data_bits is a power of two, use 256 as the mclk_multiple
// If data_bits is 24, use 192 (24 * 8) as the mclk_multiple
let mclk_multiple = if data_bits == 24 { 192 } else { 256 };
let sclk = 160_000_000; // for now it's fixed PLL_160M_CLK

let rate_hz: HertzU32 = sample_rate.into();
Expand Down